Bug 64803 – [Qt] Reapply the change that removes C++0x mode from QtWebKit

• Component: WebKit Qt
• Status: RESOLVED INVALID

[Thiago Macieira]

Reapply the change that removes C++0x mode from QtWebKit

[Thiago Macieira]

Created attachment 101326 [details]
Patch

[Ademar Reis]

Comment on attachment 101326 [details]
Patch

You need a changelog (from prepare-Changelog or webkit-patch upload) before the patch gets a r+. (no r- from me because I'm not a reviewer)

[Thiago Macieira]

Is there a script that creates a changelog?

[Benjamin Poulain]

Hey Thiago, sorry your patch was ignored.

We usually use prefix or keywords to filter the reviews for Qt. When you submit a patch, you can put the whole team in the CC list so one of review quickly.

(In reply to comment #3)
> Is there a script that creates a changelog?

./Tools/Script/prepare-changelog --bug 64803

[Benjamin Poulain]

Comment on attachment 101326 [details]
Patch

Missing Changelog explaining the change

[Alexis Menard (darktears)]

Comment on attachment 101326 [details]
Patch

I don't like the change as it doesn't help WebKit in general to support C++11 but rather workaround the problem. I think to me this should not be in trunk but rather in Qt 4.8/QtWebKit 2.2 for now.

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.