| Summary: | [Qt] Reapply the change that removes C++0x mode from QtWebKit | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Thiago Macieira <thiago> | ||||
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | benjamin, menard | ||||
| Priority: | P2 | Keywords: | Qt, QtTriaged | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Thiago Macieira
2011-07-19 09:02:38 PDT
Created attachment 101326 [details]
Patch
Comment on attachment 101326 [details]
Patch
You need a changelog (from prepare-Changelog or webkit-patch upload) before the patch gets a r+. (no r- from me because I'm not a reviewer)
Is there a script that creates a changelog? Hey Thiago, sorry your patch was ignored. We usually use prefix or keywords to filter the reviews for Qt. When you submit a patch, you can put the whole team in the CC list so one of review quickly. (In reply to comment #3) > Is there a script that creates a changelog? ./Tools/Script/prepare-changelog --bug 64803 Comment on attachment 101326 [details]
Patch
Missing Changelog explaining the change
Comment on attachment 101326 [details]
Patch
I don't like the change as it doesn't help WebKit in general to support C++11 but rather workaround the problem. I think to me this should not be in trunk but rather in Qt 4.8/QtWebKit 2.2 for now.
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. |