| Summary: | Store line number on TestExpectationLine. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||
| Component: | Tools / Tests | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 64385 | ||||||
| Attachments: |
|
||||||
|
Description
Dimitri Glazkov (Google)
2011-07-19 08:50:10 PDT
Created attachment 101325 [details]
Patch
Comment on attachment 101325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101325&action=review > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:316 > + line_number = 0 > for line in expectations_string.split("\n"): > - expectation_lines.append(cls.tokenize(line)) > + line_number += 1 No enumerate? Comment on attachment 101325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101325&action=review >> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:316 >> + line_number += 1 > > No enumerate? Not while we're running Python 2.5. Comment on attachment 101325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101325&action=review >>> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:316 >>> + line_number += 1 >> >> No enumerate? > > Not while we're running Python 2.5. 2.5 => frowns. Comment on attachment 101325 [details] Patch Clearing flags on attachment: 101325 Committed r91311: <http://trac.webkit.org/changeset/91311> All reviewed patches have been landed. Closing bug. |