Bug 64682

Summary: [EFL] Move macro checking inside ewk_view_context_menu_forward_event
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
proposed patch
none
proposed patch
kenneth: review+, webkit.review.bot: commit-queue-
updated patch
none
updated patch none

Grzegorz Czajkowski
Reported 2011-07-18 00:42:24 PDT
When CONTEXT_MENUS macro is disabled method ewk_view_context_menu_forward_event just returns EINA_FALSE and it avoid undefined reference during building.
Attachments
proposed patch (1.82 KB, patch)
2011-07-18 00:44 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
proposed patch (1.72 KB, patch)
2011-07-28 00:43 PDT, Grzegorz Czajkowski 		kenneth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
updated patch (1.55 KB, patch)
2011-08-02 23:50 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
updated patch (1.57 KB, patch)
2011-08-11 23:45 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2011-07-18 00:44:05 PDT
Created attachment 101136 [details] proposed patch
Gyuyoung Kim
Comment 2 2011-07-18 00:59:37 PDT
LGTM.
Raphael Kubo da Costa (:rakuco)
Comment 3 2011-07-18 05:53:39 PDT
Informal r+ too.
WebKit Review Bot
Comment 4 2011-07-25 00:10:58 PDT
Comment on attachment 101136 [details] proposed patch Clearing flags on attachment: 101136 Committed r91659: <http://trac.webkit.org/changeset/91659>
WebKit Review Bot
Comment 5 2011-07-25 00:11:03 PDT
All reviewed patches have been landed. Closing bug.
Grzegorz Czajkowski
Comment 6 2011-07-28 00:41:34 PDT
This patch has been overwritten in r91815 by mistake.
Grzegorz Czajkowski
Comment 7 2011-07-28 00:43:11 PDT
Created attachment 102236 [details] proposed patch Restore patch for fix ewk_view_context_menu_forward_event which has been overwrititen by mistake.
Raphael Kubo da Costa (:rakuco)
Comment 8 2011-07-28 05:41:04 PDT
r+ again.
Kenneth Rohde Christiansen
Comment 9 2011-08-02 12:02:49 PDT
Comment on attachment 102236 [details] proposed patch LGTM
WebKit Review Bot
Comment 10 2011-08-02 12:33:26 PDT
Comment on attachment 102236 [details] proposed patch Rejecting attachment 102236 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2 Last 500 characters of output: h file(s). patching file Source/WebKit/efl/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/efl/ewk/ewk_view.cpp Hunk #1 FAILED at 1589. Hunk #2 succeeded at 1396 with fuzz 1 (offset -205 lines). Hunk #3 succeeded at 1425 with fuzz 2 (offset -205 lines). 1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_view.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christia..." exit_code: 1 Full output: http://queues.webkit.org/results/9289742
Grzegorz Czajkowski
Comment 11 2011-08-02 23:50:59 PDT
Created attachment 102744 [details] updated patch Updated patch to the current changes.
Leandro Pereira
Comment 12 2011-08-03 08:21:37 PDT
Comment on attachment 102744 [details] updated patch LGTM.
Grzegorz Czajkowski
Comment 13 2011-08-11 23:45:54 PDT
Created attachment 103741 [details] updated patch Filled reviewer filed because this patch has been already reviewed.
Gyuyoung Kim
Comment 14 2011-08-11 23:53:00 PDT
Comment on attachment 103741 [details] updated patch LGTM.
WebKit Review Bot
Comment 15 2011-08-12 00:52:38 PDT
Comment on attachment 103741 [details] updated patch Clearing flags on attachment: 103741 Committed r92949: <http://trac.webkit.org/changeset/92949>
WebKit Review Bot
Comment 16 2011-08-12 00:52:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.