Summary: | Fix bugs in Array.prototype this handling. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aroben, darin, dglazkov, paulirish, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 64250 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Gavin Barraclough
2011-07-17 23:29:04 PDT
Created attachment 101131 [details]
Preliminary patch
Created attachment 101353 [details]
The patch
Comment on attachment 101353 [details] The patch Attachment 101353 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9159222 New failing tests: fast/js/string-prototype-properties.html Rolled out in 92093. This caused web compatibility issues, particularly with Mac App Store content. *** Bug 65885 has been marked as a duplicate of this bug. *** Is it possible to write a regression test for this? (In reply to comment #8) > Is it possible to write a regression test for this? Errrrrr, I did! And when I rolled the patch out I left them in the tree. So... Ooops!, forgot to commit updated (passing) LayoutTest results, landed in r96246. No test case? (In reply to comment #10) > No test case? LOL, I see the earlier comments now. |