Bug 64677

Summary: Fix bugs in String.prototype this handling.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, mathias, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 64250    
Bug Blocks:    
Attachments:
Description Flags
Preliminary patch
none
The patch oliver: review+, webkit.review.bot: commit-queue-

Gavin Barraclough
Reported 2011-07-17 23:28:58 PDT
undefined/null this values should throw TypeErrors, not convert to the global object, and primitive values should not be converted via object types.
Attachments
Preliminary patch (12.64 KB, patch)
2011-07-17 23:31 PDT, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
The patch (18.44 KB, patch)
2011-07-19 11:47 PDT, Gavin Barraclough 		oliver: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-07-17 23:31:18 PDT
Created attachment 101130 [details] Preliminary patch
Gavin Barraclough
Comment 2 2011-07-19 11:47:48 PDT
Created attachment 101352 [details] The patch
WebKit Review Bot
Comment 3 2011-07-19 12:12:23 PDT
Comment on attachment 101352 [details] The patch Attachment 101352 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9153271 New failing tests: fast/js/array-prototype-properties.html
Gavin Barraclough
Comment 4 2011-07-19 12:16:47 PDT
Fixed in r91284
Note You need to log in before you can comment on or make changes to this bug.