Summary: | [Cairo] Implement ShareableBitmap::paint() with scale factor | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | WebKit2 | Assignee: | Martin Robinson <mrobinson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, cgarcia, commit-queue, kbalazs, mrobinson, otaylor | ||||
Priority: | P2 | Keywords: | Cairo | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 74010 | ||||||
Attachments: |
|
Description
Daniel Bates
2011-07-16 21:43:55 PDT
The WinCairo Debug build fails to compile because this variant of ShareableBitmap::paint() wasn't implemented for Cairo at the time changeset 91085 <http://trac.webkit.org/changeset/91085> landed: [[ 5>libjpeg.lib(jdapistd.obj) : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance 5>LINK : warning LNK4075: ignoring '/INCREMENTAL' due to '/LTCG' specification 5> Creating library D:\Projects\BuildSlave\win-cairo-debug\build\WebKitBuild\Debug_Cairo_CFLite\lib\WebKit_debug.lib and object D:\Projects\BuildSlave\win-cairo-debug\build\WebKitBuild\Debug_Cairo_CFLite\lib\WebKit_debug.exp 5>FindIndicator.obj : error LNK2001: unresolved external symbol "public: void __thiscall WebKit::ShareableBitmap::paint(class WebCore::GraphicsContext &,float,class WebCore::IntPoint const &,class WebCore::IntRect const &)" (?paint@ShareableBitmap@WebKit@@QAEXAAVGraphicsContext@WebCore@@MABVIntPoint@4@ABVIntRect@4@@Z) 5>D:\Projects\BuildSlave\win-cairo-debug\build\WebKitBuild\Debug_Cairo_CFLite\bin\WebKit_debug.dll : fatal error LNK1120: 1 unresolved externals 5>Build log was saved at "file://D:\Projects\BuildSlave\win-cairo-debug\build\WebKitBuild\Debug_Cairo_CFLite\obj\WebKit\BuildLog.htm" 5>WebKit - 2 error(s), 1 warning(s) ]] See <http://build.webkit.org/builders/WinCairo%20Debug%20%28Build%29/builds/8691/steps/compile-webkit/logs/stdio> for more details. Committed sub method in <http://trac.webkit.org/changeset/91163>. *** This bug has been marked as a duplicate of bug 74010 *** Reopening to attach new patch. Created attachment 229062 [details]
Patch
Comment on attachment 229062 [details] Patch Clearing flags on attachment: 229062 Committed r167080: <http://trac.webkit.org/changeset/167080> All reviewed patches have been landed. Closing bug. |