Summary: | Implement WaveShaperNode for Web Audio API | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Rogers <crogers> | ||||||
Component: | New Bugs | Assignee: | Chris Rogers <crogers> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | kbr | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Chris Rogers
2011-07-15 18:02:52 PDT
Created attachment 101226 [details]
Patch
The JSC bindings need a custom setter (similar to AudioBufferSourceNode .buffer attribute) since the "exec" argument is unused (generating compile warning/error). Comment on attachment 101226 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101226&action=review The patch generally looks good but there are a couple of seemingly unrelated changes that should be split into a separate bug. > Source/WebCore/bindings/js/JSAudioContextCustom.cpp:96 > - return jsUndefined(); > + return throwVMError(exec, createSyntaxError(exec, "Error creating OfflineAudioContext")); This change looks unrelated to this patch. > Source/WebCore/bindings/js/JSAudioContextCustom.cpp:147 > - return throwVMError(exec, createSyntaxError(exec, "Invalid number of channels")); > + return throwError(exec, createSyntaxError(exec, "Invalid number of channels")); > > if (numberOfFrames <= 0) > - return throwVMError(exec, createSyntaxError(exec, "Invalid number of frames")); > + return throwError(exec, createSyntaxError(exec, "Invalid number of frames")); > > if (sampleRate <= 0) > - return throwVMError(exec, createSyntaxError(exec, "Invalid sample rate")); > + return throwError(exec, createSyntaxError(exec, "Invalid sample rate")); These as well. Created attachment 101350 [details]
Patch
New patch removes unrelated build-fix changes to JSAudioContextCustom.cpp I'll land that as a separate unreviewed build-fix Comment on attachment 101350 [details]
Patch
Looks good to me.
Committed r91281: <http://trac.webkit.org/changeset/91281> |