Bug 64635

Summary:

Refactor TestExpectationModel to use TestExpectationLine as data item.

Product:

WebKit

Reporter:

Dimitri Glazkov (Google) <dglazkov>

Component:

Tools / Tests

Assignee:

Dimitri Glazkov (Google) <dglazkov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

64385

Attachments:

Description	Flags
Patch	none
Patch	abarth: review+

Description Dimitri Glazkov (Google) 2011-07-15 15:26:30 PDT

Refactor TestExpectationModel to use TestExpectationLine as data item.

Comment 1 Dimitri Glazkov (Google) 2011-07-15 15:35:46 PDT

Created attachment 101055 [details]
Patch

Comment 2 Dimitri Glazkov (Google) 2011-07-15 15:41:19 PDT

Comment on attachment 101055 [details]
Patch

got an even better one.

Comment 3 Dimitri Glazkov (Google) 2011-07-15 15:43:14 PDT

Created attachment 101057 [details]
Patch

Comment 4 Adam Barth 2011-07-15 15:46:19 PDT

Comment on attachment 101057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101057&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:655
> -        self._model = TestExpectationsModel(port)
> +        self._model = TestExpectationsModel()

Yay!

Comment 5 Dimitri Glazkov (Google) 2011-07-15 15:49:33 PDT

Committed r91124: <http://trac.webkit.org/changeset/91124>