Bug 64635

Summary: Refactor TestExpectationModel to use TestExpectationLine as data item.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: Tools / TestsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 64385    
Attachments:
Description Flags
Patch
none
Patch abarth: review+

Dimitri Glazkov (Google)
Reported 2011-07-15 15:26:30 PDT
Refactor TestExpectationModel to use TestExpectationLine as data item.
Attachments
Patch (11.67 KB, patch)
2011-07-15 15:35 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Patch (12.31 KB, patch)
2011-07-15 15:43 PDT, Dimitri Glazkov (Google) 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-07-15 15:35:46 PDT
Created attachment 101055 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-07-15 15:41:19 PDT
Comment on attachment 101055 [details] Patch got an even better one.
Dimitri Glazkov (Google)
Comment 3 2011-07-15 15:43:14 PDT
Created attachment 101057 [details] Patch
Adam Barth
Comment 4 2011-07-15 15:46:19 PDT
Comment on attachment 101057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101057&action=review > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:655 > - self._model = TestExpectationsModel(port) > + self._model = TestExpectationsModel() Yay!
Dimitri Glazkov (Google)
Comment 5 2011-07-15 15:49:33 PDT
Committed r91124: <http://trac.webkit.org/changeset/91124>
Note You need to log in before you can comment on or make changes to this bug.