Summary: | Add isSpeechInputEnabled flag to WebContextMenuData | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | gshires | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | fishd, satish, tonyg, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 39485 | ||||||||
Attachments: |
|
Description
gshires
2011-07-15 13:55:01 PDT
+Darin to approve the addition to WebKit/chromium/public API All patches should have an entry to the appropriate ChangeLog file. For this patch, please add an entry to WebKit/ChangeLog. You can do this with the 'Tools/Scripts/prepare-ChangeLog' script. For more info see http://www.webkit.org/coding/contributing.html#changelogs ContextMenuClientImpl.cpp:264 - should indent by 4 spaces, not 2. Created attachment 101363 [details]
Proposed patch
Fixed spacing and added ChangeLog entry.
Comment on attachment 101363 [details]
Proposed patch
For future reference, when you want a reviewer to add a patch to the commit queue for you just set the cq field to "?". Some committers like to commit manually and it is hard to remember who has committer rights, so typically reviewers will not cq+ unless it is requested.
Comment on attachment 101363 [details] Proposed patch Clearing flags on attachment: 101363 Committed r91377: <http://trac.webkit.org/changeset/91377> All reviewed patches have been landed. Closing bug. |