Bug 64599

Summary: Web Inspector: Web Inspector: provide unique identifiers for loaders
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Vsevolod Vlasov 2011-07-15 07:53:53 PDT
Currently, we use loader address as a loader id, this does not guarantee loader ids to be unique through the life time of the process.
We now use the same technique used to create unique frame ids for loaders.
Comment 1 Vsevolod Vlasov 2011-07-15 07:57:53 PDT
Created attachment 100979 [details]
Patch
Comment 2 Vsevolod Vlasov 2011-07-15 11:17:37 PDT
Created attachment 101010 [details]
Patch
Comment 3 Pavel Feldman 2011-07-18 05:43:21 PDT
Comment on attachment 101010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101010&action=review

> Source/WebCore/inspector/InspectorPageAgent.h:135
> +    HashMap<DocumentLoader*, String> m_loaderToIdentifier;

Could you make this field static?
Comment 4 WebKit Review Bot 2011-07-18 07:04:43 PDT
Comment on attachment 101010 [details]
Patch

Clearing flags on attachment: 101010

Committed r91184: <http://trac.webkit.org/changeset/91184>
Comment 5 WebKit Review Bot 2011-07-18 07:04:47 PDT
All reviewed patches have been landed.  Closing bug.