Bug 64599

Summary: Web Inspector: Web Inspector: provide unique identifiers for loaders
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Vsevolod Vlasov
Reported 2011-07-15 07:53:53 PDT
Currently, we use loader address as a loader id, this does not guarantee loader ids to be unique through the life time of the process. We now use the same technique used to create unique frame ids for loaders.
Attachments
Patch (7.67 KB, patch)
2011-07-15 07:57 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (7.71 KB, patch)
2011-07-15 11:17 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2011-07-15 07:57:53 PDT
Created attachment 100979 [details] Patch
Vsevolod Vlasov
Comment 2 2011-07-15 11:17:37 PDT
Created attachment 101010 [details] Patch
Pavel Feldman
Comment 3 2011-07-18 05:43:21 PDT
Comment on attachment 101010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101010&action=review > Source/WebCore/inspector/InspectorPageAgent.h:135 > + HashMap<DocumentLoader*, String> m_loaderToIdentifier; Could you make this field static?
WebKit Review Bot
Comment 4 2011-07-18 07:04:43 PDT
Comment on attachment 101010 [details] Patch Clearing flags on attachment: 101010 Committed r91184: <http://trac.webkit.org/changeset/91184>
WebKit Review Bot
Comment 5 2011-07-18 07:04:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.