Bug 64597

Summary: [Qt] Push the new viewport rect to the drawing area when committing the scale.
Product: WebKit Reporter: Jocelyn Turcotte <jturcotte>
Component: New BugsAssignee: Jocelyn Turcotte <jturcotte>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch benjamin: review+

Jocelyn Turcotte
Reported 2011-07-15 06:45:23 PDT
[Qt] Push the new viewport rect to the drawing area when committing the scale.
Attachments
Patch (5.20 KB, patch)
2011-07-15 06:50 PDT, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
Patch (1.41 KB, patch)
2011-07-15 08:15 PDT, Jocelyn Turcotte 		benjamin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2011-07-15 06:50:30 PDT
Created attachment 100970 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2011-07-15 06:53:01 PDT
Comment on attachment 100970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100970&action=review > Source/WebKit2/UIProcess/API/qt/qtouchwebpage.cpp:130 > page->setContentsScale(q->scale()); > + viewport->d->viewportRectUpdated(); I am wondering, when we have suspend/resume working we could update this (and visibleContentRect) when resuming.
Benjamin Poulain
Comment 3 2011-07-15 06:58:01 PDT
I would prefer if the page was not calling functions on the viewport. I am always afraid of coming back to the old code where every class knew about the internal of every other classes. It feels like TouchViewInterface might be the right place to call viewportRectUpdated()?
Jocelyn Turcotte
Comment 4 2011-07-15 08:15:10 PDT
Created attachment 100984 [details] Patch Simpler patch after removing the scale commit timer (see bug 64600).
Benjamin Poulain
Comment 5 2011-07-15 08:23:08 PDT
Comment on attachment 100984 [details] Patch Nice.
Jocelyn Turcotte
Comment 6 2011-07-18 06:48:31 PDT
Committed r91182: <http://trac.webkit.org/changeset/91182>
Note You need to log in before you can comment on or make changes to this bug.