| Summary: | Upstream QtWebKit/N9 changes related to visibleContentRect | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kenneth Rohde Christiansen <kenneth> | ||||||||||
| Component: | Layout and Rendering | Assignee: | Kenneth Rohde Christiansen <kenneth> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | webkit.review.bot, zherczeg | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Kenneth Rohde Christiansen
2011-07-15 02:00:04 PDT
Created attachment 100949 [details]
Patch
Attachment 100949 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit2/UIProcess/WebPageProxy.h:340: The parameter name "rect" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 100949 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100949&action=review r=me but fix the style issue before landing I'd say. > Source/WebCore/platform/ScrollView.cpp:240 > - IntSize(max(0, m_boundsSize.width() - verticalScrollbarWidth), > + IntSize(max(0, m_boundsSize.width() - verticalScrollbarWidth), You could skip this part when landing :) Created attachment 100954 [details]
Patch for landing
Created attachment 100955 [details]
Patch for landing
Comment on attachment 100955 [details] Patch for landing Clearing flags on attachment: 100955 Committed r91064: <http://trac.webkit.org/changeset/91064> All reviewed patches have been landed. Closing bug. This patch killed the Qt buildbot (early exit after 500 fail): http://build.webkit.org/builders/Qt%20Linux%20Release/builds/35397/steps/layout-test/logs/stdio any idea? (In reply to comment #8) > This patch killed the Qt buildbot (early exit after 500 fail): http://build.webkit.org/builders/Qt%20Linux%20Release/builds/35397/steps/layout-test/logs/stdio > > any idea? Strange. We are not running the bots using tiling and fixed layout, so this shouldnt be affected. I think I found the issue. void FrameLoaderClientQt::transitionToCommittedForNewPage() doesn't check if it is in resize to contents mode. Patch in the making Created attachment 100995 [details]
Regression fix
Attachment 100995 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1
Source/WebKit/qt/ChangeLog:3: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 100995 [details] Regression fix Clearing flags on attachment: 100995 Committed r91079: <http://trac.webkit.org/changeset/91079> All reviewed patches have been landed. Closing bug. |