Summary: | gardening server should proxy buildbot status for garden-o-matic | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dglazkov, eric, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 64190 | ||||||
Attachments: |
|
Description
Adam Barth
2011-07-15 01:48:50 PDT
Created attachment 100948 [details]
Patch
Comment on attachment 100948 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100948&action=review OK. > Tools/Scripts/webkitpy/tool/mocktool.py:841 > + self._chromium_buildbot = MockBuildBot() MIght want to give it a differnet url. > Tools/Scripts/webkitpy/tool/mocktool.py:859 > + def chromium_buildbot(self): > + return self._chromium_buildbot we should figure out if we should move to @property-style getters one of these days. (In reply to comment #2) > (From update of attachment 100948 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100948&action=review > > > Tools/Scripts/webkitpy/tool/mocktool.py:841 > > + self._chromium_buildbot = MockBuildBot() > > MIght want to give it a differnet url. Yeah, I thought about that, but then I decided it didn't really matter. We can do that once we have our first bot about using the wrong one. > > Tools/Scripts/webkitpy/tool/mocktool.py:859 > > + def chromium_buildbot(self): > > + return self._chromium_buildbot > > we should figure out if we should move to @property-style getters one of these days. I agree that it's super annoying that some of these require function calls and some don't need the (). It won't actually be that hard to fix globally. We could rename tool to host at the same time. Comment on attachment 100948 [details] Patch Clearing flags on attachment: 100948 Committed r91144: <http://trac.webkit.org/changeset/91144> All reviewed patches have been landed. Closing bug. |