Bug 64576

Summary: Add regression tests for legacy color parsing of valid CSS colors
Product: WebKit Reporter: Tab Atkins <tabatkins>
Component: DOMAssignee: Tab Atkins <tabatkins>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tab Atkins
Reported 2011-07-14 17:35:46 PDT
Using a valid CSS color other than a named color or a 3/6 digit hex color should use the legacy parsing code, rather than accepting the value and treating it like a valid CSS color. There aren't currently enough regression tests surrounding this. Specifically, we seem to need tests for "currentColor", the rgba() function, and the hsl() and hsla() functions.
Attachments
Patch (3.23 KB, patch)
2011-07-18 14:50 PDT, Tab Atkins 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tab Atkins
Comment 1 2011-07-18 14:50:23 PDT
Created attachment 101206 [details] Patch
Tab Atkins
Comment 2 2011-07-18 14:51:50 PDT
Newly added people, can I get a quick r+? This is just a four-line addition to the tests, plus updated expectations.
WebKit Review Bot
Comment 3 2011-07-18 15:49:51 PDT
Comment on attachment 101206 [details] Patch Clearing flags on attachment: 101206 Committed r91217: <http://trac.webkit.org/changeset/91217>
WebKit Review Bot
Comment 4 2011-07-18 15:49:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.