Bug 64569

Summary: Support "Jump to Selection" in WebKit2 on Mac
Product: WebKit Reporter: Ada Chan <adachan>
Component: WebKit2Assignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch (2nd version) andersca: review+

Ada Chan
Reported 2011-07-14 16:03:25 PDT
To do this, we need to implement the CenterSelectionInVisibleArea editor command in WebCore. <rdar://problem/9732174>
Attachments
Patch (4.99 KB, patch)
2011-07-14 16:36 PDT, Ada Chan 		no flags
DetailsFormatted DiffDiff
Patch (2nd version) (5.19 KB, patch)
2011-07-15 13:18 PDT, Ada Chan 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2011-07-14 16:36:12 PDT
Created attachment 100893 [details] Patch
Ada Chan
Comment 2 2011-07-15 13:17:15 PDT
I forgot that besides scrolling the selection into view, I also need to flash the find indicator (bounce the yellow bubble around the selection) when that command is triggered. I'm going to send a new patch, and since the find indicator is not part of WebCore, I might as well just handle everything within WebKit.
Ada Chan
Comment 3 2011-07-15 13:18:11 PDT
Created attachment 101032 [details] Patch (2nd version)
Ada Chan
Comment 4 2011-09-14 09:52:17 PDT
Committed: http://trac.webkit.org/changeset/91108
Note You need to log in before you can comment on or make changes to this bug.