Bug 64568 – REGRESSION: webkit-patch roll-chromium-deps is broken

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Ryosuke Niwa]

webkit-patch roll-chromium-deps blows up with the following error:

rniwa-macpro:webkit2 rniwa$ Tools/Scripts/webkit-patch roll-chromium-deps 92606
Traceback (most recent call last):
  File "Tools/Scripts/webkit-patch", line 66, in <module>
    main()
  File "Tools/Scripts/webkit-patch", line 61, in main
    WebKitPatch(__file__).main()
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 51, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/steps/updatechromiumdeps.py", line 69, in run
    deps = self._tool.checkout().chromium_deps()
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 151, in chromium_deps
    return DEPS(self._scm.absolute_path("Source", "WebKit", "chromium", "DEPS"))
TypeError: absolute_path() takes exactly 2 arguments (5 given)

[Ryosuke Niwa]

Created attachment 100884 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 100884 [details]
Patch

LGTM too.  Sorry for the trouble.  We really should test this method....

[Ryosuke Niwa]

Created attachment 100889 [details]
Patch

[Ryosuke Niwa]

Committed r91033: <http://trac.webkit.org/changeset/91033>