Bug 64560

Summary: [Qt] Compiling error in Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp with Qt 4.7 or older
Product: WebKit Reporter: Hui Huang <hui_huang>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hui_huang, laszlo.gombos, webkit.review.bot
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
noam: review-, noam: commit-queue-
Patch with changes based on review none

Hui Huang
Reported Thursday, July 14, 2011 10:07:30 PM UTC
The following line in the function tst_QWebElement::render() doesn't compile on Qt 4.7 or older versions: tables[0].render(&painter, chunkPaintRect); The method void QWebElement::render(QPainter * painter, const QRect & clip) is introduced in Qt 4.8 (http://doc.qt.nokia.com/4.8-snapshot/qwebelement.html#render). It is not available in Qt 4.7 or older (http://doc.qt.nokia.com/4.7/qwebelement.html#render).
Attachments
Proposed patch (1.35 KB, patch)
2011-07-15 07:56 PDT, Hui Huang
noam: review-
noam: commit-queue-
Patch with changes based on review (1.36 KB, patch)
2011-07-18 08:15 PDT, Hui Huang
no flags
Hui Huang
Comment 1 Friday, July 15, 2011 3:56:02 PM UTC
Created attachment 100977 [details] Proposed patch
Noam Rosenthal
Comment 2 Saturday, July 16, 2011 11:00:22 PM UTC
Comment on attachment 100977 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=100977&action=review > Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp:1026 > +#if QT_VERSION >= 0x040800 Please use QT_VERSION_CHECK(4, 8, 0) instead of 0x040800
Hui Huang
Comment 3 Monday, July 18, 2011 3:20:02 PM UTC
Thanks for reviewing the patch. I just made the change and it compiled without any problem. I will submit the new patch. (In reply to comment #2) > (From update of attachment 100977 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100977&action=review > > > Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp:1026 > > +#if QT_VERSION >= 0x040800 > > Please use QT_VERSION_CHECK(4, 8, 0) instead of 0x040800
Hui Huang
Comment 4 Monday, July 18, 2011 4:15:13 PM UTC
Created attachment 101159 [details] Patch with changes based on review
WebKit Review Bot
Comment 5 Monday, July 18, 2011 6:13:00 PM UTC
Comment on attachment 101159 [details] Patch with changes based on review Clearing flags on attachment: 101159 Committed r91193: <http://trac.webkit.org/changeset/91193>
WebKit Review Bot
Comment 6 Monday, July 18, 2011 6:13:04 PM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.