Summary: | [Qt] Compiling error in Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp with Qt 4.7 or older | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hui Huang <hui_huang> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | hui_huang, laszlo.gombos, webkit.review.bot | ||||||
Priority: | P3 | Keywords: | Qt | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Hui Huang
2011-07-14 14:07:30 PDT
Created attachment 100977 [details]
Proposed patch
Comment on attachment 100977 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=100977&action=review > Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp:1026 > +#if QT_VERSION >= 0x040800 Please use QT_VERSION_CHECK(4, 8, 0) instead of 0x040800 Thanks for reviewing the patch. I just made the change and it compiled without any problem. I will submit the new patch. (In reply to comment #2) > (From update of attachment 100977 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100977&action=review > > > Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp:1026 > > +#if QT_VERSION >= 0x040800 > > Please use QT_VERSION_CHECK(4, 8, 0) instead of 0x040800 Created attachment 101159 [details]
Patch with changes based on review
Comment on attachment 101159 [details] Patch with changes based on review Clearing flags on attachment: 101159 Committed r91193: <http://trac.webkit.org/changeset/91193> All reviewed patches have been landed. Closing bug. |