Bug 64554

Summary: Remove the notion of TestExpectationLine.valid, start storing parsing errors in expectations themselves.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: Tools / TestsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 64531    
Bug Blocks: 64385, 64559    
Attachments:
Description Flags
Patch none

Description Dimitri Glazkov (Google) 2011-07-14 13:01:59 PDT
Remove the notion of TestExpectationLine.valid, start storing parsing errors in expectations themselves.
Comment 1 Dimitri Glazkov (Google) 2011-07-14 13:09:53 PDT
Created attachment 100852 [details]
Patch
Comment 2 Adam Barth 2011-07-14 22:47:43 PDT
Comment on attachment 100852 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100852&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:726
> +            modifiers = [o for o in options if o in self.MODIFIERS]

normally we'd use the variable option instead of o
Comment 3 Adam Barth 2011-07-14 22:48:40 PDT
Comment on attachment 100852 [details]
Patch

I mean, I feel like I don't fully understand this change, which makes me hesitant to review it.  However, the direction looks good.
Comment 4 Dimitri Glazkov (Google) 2011-07-15 08:51:43 PDT
Comment on attachment 100852 [details]
Patch

Clearing flags on attachment: 100852

Committed r91071: <http://trac.webkit.org/changeset/91071>
Comment 5 Dimitri Glazkov (Google) 2011-07-15 08:51:48 PDT
All reviewed patches have been landed.  Closing bug.