Bug 64539

Summary: Remove LegacyDefaultOptionalArguments flag from FileAPI
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, adamk, ericu, kinuko, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mark Pilgrim (Google)
Reported 2011-07-14 10:32:47 PDT
As per discussion in IRC, we are tightening up the semantics of APIs, starting with the newer APIs and working backwards. This change will make "required" arguments actually required across the File API.
Attachments
Patch (10.58 KB, patch)
2011-07-14 10:34 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2011-07-14 10:34:17 PDT
Created attachment 100826 [details] Patch
Adam Barth
Comment 2 2011-07-14 18:45:09 PDT
Comment on attachment 100826 [details] Patch I've added some folks who work on the File API to make this this patch is fine with them. Please give them some time to respond to the bug before landing.
Adam Klein
Comment 3 2011-07-15 15:58:07 PDT
This looks right to me (especially if the tests pass), but Kinuko probably has a bit more context on the WebKit side of things than Eric, so adding her too.
Kinuko Yasuda
Comment 4 2011-07-18 22:40:04 PDT
This looks good to me, but is it really ok/agreed to make them "required" while the spec still say they are optional? (Just asking)
Adam Barth
Comment 5 2011-07-19 00:31:14 PDT
(In reply to comment #4) > This looks good to me, but is it really ok/agreed to make them "required" while the spec still say they are optional? (Just asking) Does the spec say that they're optional?
Kinuko Yasuda
Comment 6 2011-07-19 01:02:21 PDT
Sorry I was mistaken; this change makes "required" arguments required-- sounds good then!
Adam Barth
Comment 7 2011-07-19 01:07:39 PDT
Comment on attachment 100826 [details] Patch Thanks!
Mark Pilgrim (Google)
Comment 8 2011-07-21 10:41:29 PDT
Adam, can you please land this patch now?
WebKit Review Bot
Comment 9 2011-07-21 12:14:00 PDT
Comment on attachment 100826 [details] Patch Clearing flags on attachment: 100826 Committed r91486: <http://trac.webkit.org/changeset/91486>
WebKit Review Bot
Comment 10 2011-07-21 12:14:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.