| Summary: | REGRESSION (r90809): Setting a checkbox's checked property, doesn't render as checked until app window loses focus | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joel <joel> | ||||||||
| Component: | Layout and Rendering | Assignee: | Kent Tamura <tkent> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ap, darin, dominicc, huiqing.zeng, tkent, webkit.review.bot | ||||||||
| Priority: | P1 | Keywords: | InRadar, Regression | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Mac (Intel) | ||||||||||
| OS: | OS X 10.6 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 100915 [details]
Patch
Comment on attachment 100915 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100915&action=review > LayoutTests/ChangeLog:3 > + REGRESSION (r90809): Setting a checkbox's checked property, doesn't render as checked until app window looses focus loses > Source/WebCore/ChangeLog:3 > + REGRESSION (r90809): Setting a checkbox's checked property, doesn't render as checked until app window looses focus loses Created attachment 100916 [details]
Patch 2
Fix typo
Comment on attachment 100916 [details]
Patch 2
I don’t understand why it is correct to only call updateCheckedRadioButtons for radio buttons. The work in there does not seem to be radio-button-specific despite the function’s name. If that is correct, then the function should be moved into RadioInputType out of HTMLInputElement.
Thank you for reviewing. (In reply to comment #5) > (From update of attachment 100916 [details]) > I don’t understand why it is correct to only call updateCheckedRadioButtons for radio buttons. The work in there does not seem to be radio-button-specific despite the function’s name. If that is correct, then the function should be moved into RadioInputType out of HTMLInputElement. I think updateCheckedRadioButton() is really specific to radio buttons, and we should move it to RadioInputType. Comment on attachment 100916 [details] Patch 2 Clearing flags on attachment: 100916 Committed r91047: <http://trac.webkit.org/changeset/91047> All reviewed patches have been landed. Closing bug. |
Created attachment 100822 [details] Click a row, to see the issue When you set a checkbox's checked property, webkit nightly isn't rendering a checked view of the icon until you remove focus from the entire application window. It is actually checked though, so it's just a visual bug. Works everywhere else, chrome, firefox, safari