Bug 64515

Summary: [EFL] Add OwnPtr specialization for Ecore_Pipe.
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 64337    
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2011-07-14 00:18:15 PDT
It's needed for Bug 64337.
Attachments
Patch (1.94 KB, patch)
2011-07-14 00:25 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (2.01 KB, patch)
2011-07-14 01:07 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2011-07-14 00:25:35 PDT
Created attachment 100781 [details] Patch
Ryuan Choi
Comment 2 2011-07-14 00:28:31 PDT
The style bot will complain struct name, but it's false positive.
WebKit Review Bot
Comment 3 2011-07-14 00:28:33 PDT
Attachment 100781 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/OwnPtrCommon.h:55: Ecore_Pipe is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gyuyoung Kim
Comment 4 2011-07-14 00:56:18 PDT
Comment on attachment 100781 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100781&action=review LGTM except for changelog. > Source/JavaScriptCore/ChangeLog:5 > + Though this patch is clear, do you need to add simple description for this patch ?
Ryuan Choi
Comment 5 2011-07-14 01:07:46 PDT
Created attachment 100785 [details] Patch
Ryuan Choi
Comment 6 2011-07-14 01:08:14 PDT
(In reply to comment #4) > (From update of attachment 100781 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100781&action=review > > LGTM except for changelog. > > > Source/JavaScriptCore/ChangeLog:5 > > + > > Though this patch is clear, do you need to add simple description for this patch ? I update changelog.
WebKit Review Bot
Comment 7 2011-07-14 01:09:16 PDT
Attachment 100785 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/OwnPtrCommon.h:55: Ecore_Pipe is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Raphael Kubo da Costa (:rakuco)
Comment 8 2011-07-14 06:42:35 PDT
LGTM, we just need to find a willing reviewer now.
Xan Lopez
Comment 9 2011-07-14 07:34:28 PDT
Comment on attachment 100785 [details] Patch Looks good. You should figure out a way of teaching the style scripts to ignore your types.
WebKit Review Bot
Comment 10 2011-07-14 11:02:59 PDT
Comment on attachment 100785 [details] Patch Clearing flags on attachment: 100785 Committed r91018: <http://trac.webkit.org/changeset/91018>
WebKit Review Bot
Comment 11 2011-07-14 11:03:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.