Summary: | Move webkitpy off of loose mocks | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dbates, rniwa | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2011-07-13 19:41:41 PDT
Created attachment 100757 [details]
Patch
Still needs a little lovin to pass all the unit tests. Comment on attachment 100757 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100757&action=review > Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:39 > + tool._scm = Mock() wait! this is a loose mock! Created attachment 100763 [details]
Patch
Comment on attachment 100763 [details]
Patch
Very nice.
Committed r90978: <http://trac.webkit.org/changeset/90978> Comment on attachment 100763 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100763&action=review > Tools/Scripts/webkitpy/common/checkout/scm/git.py:111 > @classmethod > def to_object_name(cls, filepath): > - root_end_with_slash = os.path.join(cls.find_checkout_root(os.path.dirname(filepath)), '') > + root_end_with_slash = self._filesystem.join(cls.find_checkout_root(self._filesystem.dirname(filepath)), '') File "/Volumes/d2/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py", line 111, in to_object_name root_end_with_slash = self._filesystem.join(cls.find_checkout_root(self._filesystem.dirname(filepath)), '') NameError: global name 'self' is not defined rebaseline-chromium-webkit-tests doesn't work because of this error. Sorry. I wish rebaseline-chromium-tests has more unittesting... this is the second typo from that change which broke rebaseline-chromium-tests. Committed r91045: <http://trac.webkit.org/changeset/91045> |