Bug 64462

Summary: Introduce TestExpectationSerializer.list_to_string.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 64385    
Attachments:
Description Flags
Patch
none
Better?
none
Better? none

Dimitri Glazkov (Google)
Reported 2011-07-13 10:21:48 PDT
Introduce TestExpectationSerializer.list_to_string.
Attachments
Patch (4.07 KB, patch)
2011-07-13 10:22 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Better? (13.26 KB, patch)
2011-07-13 10:45 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Better? (4.14 KB, patch)
2011-07-13 10:46 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-07-13 10:22:57 PDT
Created attachment 100682 [details] Patch
Adam Barth
Comment 2 2011-07-13 10:24:20 PDT
Comment on attachment 100682 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100682&action=review > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:514 > + return TestExpectationSerializer.list_to_string([expectation for expectation in self._expectations if not (expectation.valid and expectation.name in tests and "rebaseline" in expectation.modifiers)]) OMG! Can we break out a helper function here somewhere?
Dimitri Glazkov (Google)
Comment 3 2011-07-13 10:31:17 PDT
(In reply to comment #2) > (From update of attachment 100682 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100682&action=review > > > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:514 > > + return TestExpectationSerializer.list_to_string([expectation for expectation in self._expectations if not (expectation.valid and expectation.name in tests and "rebaseline" in expectation.modifiers)]) > > OMG! Can we break out a helper function here somewhere? Lemme try.
Dimitri Glazkov (Google)
Comment 4 2011-07-13 10:45:24 PDT
Created attachment 100683 [details] Better?
Dimitri Glazkov (Google)
Comment 5 2011-07-13 10:46:29 PDT
Created attachment 100684 [details] Better?
Adam Barth
Comment 6 2011-07-13 10:52:36 PDT
Comment on attachment 100684 [details] Better? Thanks. Much more understandable!
Dimitri Glazkov (Google)
Comment 7 2011-07-13 12:40:15 PDT
Comment on attachment 100684 [details] Better? Clearing flags on attachment: 100684 Committed r90942: <http://trac.webkit.org/changeset/90942>
Dimitri Glazkov (Google)
Comment 8 2011-07-13 12:40:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.