| Summary: | [Qt] Make ownerWidget into a free functions | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kenneth Rohde Christiansen <kenneth> | ||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, kling, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Comment on attachment 100671 [details]
Patch
r=me, but missing bug URL in ChangeLog brah!
Attachment 100671 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp:26: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Don't waste your time with that. Don't forget Qt 5 is the next step, we won't need that function soon. |
Created attachment 100671 [details] Patch SSIA