Summary: | Improve names of some ApplicationCacheStorage accessor methods | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, joepeck | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Created attachment 100629 [details]
[PATCH] Rename the functions
Landed in r90948 <http://trac.webkit.org/changeset/90948>. |
In an earlier patch review Alexey mentioned: > > Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp:827 > > + // Failed to determine what is left in the quota. Fallback to allowing anything. > > It's a bad coding style violation that a function called remainingSizeForOriginExcludingCache() > returns a boolean, not the remaining size. This is a pre-existing issue, and not something you > did in this patch. There are a few functions that should be updated: quotaForOrigin, usageForOrigin, and remainingSizeForOriginExcludingCache I'll fix them with the suggested rename calculate...()