Bug 64422

Summary: Adjust garden-o-matic layout to use fewer lines
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 64188    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2011-07-12 19:16:45 PDT
Adjust garden-o-matic layout to use fewer lines
Attachments
Patch (4.36 KB, patch)
2011-07-12 19:18 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-07-12 19:18:23 PDT
Created attachment 100607 [details] Patch
Adam Barth
Comment 2 2011-07-12 19:22:58 PDT
+ojan Thanks for reviewing these patches!
Ojan Vafai
Comment 3 2011-07-12 19:24:56 PDT
Comment on attachment 100607 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100607&action=review > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:35 > + '<div class="when">' + Do you still need the "when" classname? It makes less sense now that it includes failure count.
Adam Barth
Comment 4 2011-07-12 19:31:34 PDT
(In reply to comment #3) > (From update of attachment 100607 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100607&action=review > > > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:35 > > + '<div class="when">' + > > Do you still need the "when" classname? It makes less sense now that it includes failure count. Yeah, I'm not sure we do. This stuff is mostly cargo-cult from dglazkov's mocks.
Adam Barth
Comment 5 2011-07-12 19:39:57 PDT
I'm going to leave it for now. It's not hurting anyone.
Adam Barth
Comment 6 2011-07-12 19:41:24 PDT
Comment on attachment 100607 [details] Patch Clearing flags on attachment: 100607 Committed r90881: <http://trac.webkit.org/changeset/90881>
Adam Barth
Comment 7 2011-07-12 19:41:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.