Bug 64397 – Added the ability to dynamically change the parent context of a WebGraphicsContext3D.

• Component: WebGL
• Status: RESOLVED FIXED

[Al]

Added the ability to dynamically change the parent context of a WebGraphicsContext3D.

GraphicsContext3DInternal::platformTexture uses this to set the parent as appropriate.

This is to fix the bug where a WebGL canvas cannot be moved to a newly opened window in Chrome.

[Al]

Created attachment 100566 [details]
Patch

[WebKit Review Bot]

Attachment 100566 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1

Source/WebKit/chromium/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit/chromium/public/WebGraphicsContext3D.h:135:  parent_context is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kenneth Russell]

Comment on attachment 100566 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100566&action=review

Please clean up the style issues and re-upload the patch.

> Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:146
> +    m_impl->setParentContext(m_webViewImpl->graphicsContext3D());

Does this still work if accelerated compositing is turned off (i.e., with the command line argument --disable-accelerated-compositing)?

[Al]

Created attachment 100585 [details]
Patch 2

[Al]

Comment on attachment 100566 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100566&action=review

>> Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:146
>> +    m_impl->setParentContext(m_webViewImpl->graphicsContext3D());
> 
> Does this still work if accelerated compositing is turned off (i.e., with the command line argument --disable-accelerated-compositing)?

Yeah. platformTexture doesn't get called when the accelerated compositor is turned off.

[Kenneth Russell]

Comment on attachment 100585 [details]
Patch 2

OK, seems fine as long as it's been tested.

[WebKit Review Bot]

Comment on attachment 100585 [details]
Patch 2

Clearing flags on attachment: 100585

Committed r90878: <http://trac.webkit.org/changeset/90878>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.