Bug 64394

Summary: cr-linux-ews should run pixel tests
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, jamesr, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2011-07-12 14:34:07 PDT
cr-linux-ews should run pixel tests
Attachments
Patch (3.41 KB, patch)
2011-07-12 14:36 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-07-12 14:36:18 PDT
Created attachment 100564 [details] Patch
Ojan Vafai
Comment 2 2011-07-12 14:39:35 PDT
Comment on attachment 100564 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100564&action=review > Tools/ChangeLog:9 > + test on the bots, it looks like we have five pixel failures, related to I'm confused, won't these 5 tests start failing on every run now? > Tools/ChangeLog:11 > + avoid uploading huge zip files to bugs.webkit.org (with all the exected typo:exected
Adam Barth
Comment 3 2011-07-12 14:41:07 PDT
(In reply to comment #2) > (From update of attachment 100564 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100564&action=review > > > Tools/ChangeLog:9 > > + test on the bots, it looks like we have five pixel failures, related to > > I'm confused, won't these 5 tests start failing on every run now? Yes, but we have code to recognize persistent failures and ignore them.
Ojan Vafai
Comment 4 2011-07-12 14:42:13 PDT
Comment on attachment 100564 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100564&action=review >>> Tools/ChangeLog:9 >>> + test on the bots, it looks like we have five pixel failures, related to >> >> I'm confused, won't these 5 tests start failing on every run now? > > Yes, but we have code to recognize persistent failures and ignore them. That sounds scary.
Adam Barth
Comment 5 2011-07-12 14:52:59 PDT
(In reply to comment #4) > (From update of attachment 100564 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100564&action=review > > >>> Tools/ChangeLog:9 > >>> + test on the bots, it looks like we have five pixel failures, related to > >> > >> I'm confused, won't these 5 tests start failing on every run now? > > > > Yes, but we have code to recognize persistent failures and ignore them. > > That sounds scary. There's an upper bound on how many failures to ignore. It's been working for us so far. If it causes problems, we can re-evaluate later.
WebKit Review Bot
Comment 6 2011-07-12 15:35:41 PDT
Comment on attachment 100564 [details] Patch Clearing flags on attachment: 100564 Committed r90864: <http://trac.webkit.org/changeset/90864>
WebKit Review Bot
Comment 7 2011-07-12 15:35:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.