| Summary: | Isolate HTMLTextFormControlElement into a separate file | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||||
| Component: | Forms | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | abarth, darin, dglazkov, eric, ojan, tkent, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
You are a brave man. Adding files to the project is so painful. :( Created attachment 100543 [details]
Patch
The patch is gigantic because I svn cp'ed HTMLFormControlElement.h and HTMLFormControlElement.cpp but this should be a long-term win 'cause it preserve svn blame list. Attachment 100543 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/html/HTMLTextFormControlElement.cpp:26: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Source/WebCore/html/HTMLTextFormControlElement.cpp:28: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 100546 [details]
Fixed include in HTMLTextFormControlElement.cpp
Comment on attachment 100546 [details]
Fixed include in HTMLTextFormControlElement.cpp
Oops, HTMLTextFormControlElement.cpp was including HTMLFormControlElement.h instead of HTMLTextFormControlElement.h.
Comment on attachment 100546 [details] Fixed include in HTMLTextFormControlElement.cpp Attachment 100546 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9022251 New failing tests: editing/pasteboard/drag-drop-input-textarea.html editing/pasteboard/drop-text-events.html editing/pasteboard/copy-backslash-with-euc.html editing/input/div-first-child-rule-textarea.html editing/input/ime-composition-clearpreedit.html editing/input/insert-wrapping-space-in-textarea.html editing/selection/delete-word-granularity-text-control.html editing/input/set-value-on-input-and-type-input.html editing/input/set-value-on-input-and-type-textarea.html editing/input/set-value-on-input-and-delete.html editing/deleting/delete-ligature-001.html editing/deleting/5290534.html editing/pasteboard/paste-text-events.html editing/inserting/typing-tab-designmode-forms.html editing/input/div-first-child-rule-input.html editing/pasteboard/copy-null-characters.html editing/spelling/spellcheck-paste.html editing/undo/5658727.html editing/pasteboard/drag-drop-url-text.html editing/selection/drag-text-delay.html Created attachment 100550 [details]
Archive of layout-test-results from ec2-cr-linux-01
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 100555 [details]
fixed test failures
I forgot to replace calls to HTMLFormControlElementWithState::defaultEventHandler by calls to HTMLTextFormControlElement::defaultEventHandler. Fixed this and now tests pass. Thanks for the review, Dimitri! Committed r90849: <http://trac.webkit.org/changeset/90849> |
HTMLFormControlElement.h: // FIXME: Give this class its own header file. class HTMLTextFormControlElement : public HTMLFormControlElementWithState { Let's do it.