| Summary: | TestFailures page thinks all tests passed in http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14672 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
| Component: | Tools / Tests | Assignee: | Adam Roben (:aroben) <aroben> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, dbates, ddkilzer, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Adam Roben (:aroben)
2011-07-12 07:13:15 PDT
Created attachment 100481 [details]
Patch
Comment on attachment 100481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100481&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:156 > + result.failureCount = -1; I take it that you've ensured that the callsites can handle failureCount = -1. Briefly looking through the code this appears to be true. Comment on attachment 100481 [details] Patch Clearing flags on attachment: 100481 Committed r90824: <http://trac.webkit.org/changeset/90824> All reviewed patches have been landed. Closing bug. Comment on attachment 100481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100481&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:156 >> + result.failureCount = -1; > > I take it that you've ensured that the callsites can handle failureCount = -1. Briefly looking through the code this appears to be true. Yes. It was already possible for this function to return -1 in some cases, so callers have been expecting it for a while. |