Bug 64354

Summary: [EFL] Implement EFL-specific current time and monotonicallyIncreasingTime.
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ryuan Choi
Reported 2011-07-12 05:34:14 PDT
Patch will be added.
Attachments
Patch (1.93 KB, patch)
2011-07-12 20:56 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2011-07-12 20:56:48 PDT
Created attachment 100618 [details] Patch
Gyuyoung Kim
Comment 2 2011-07-12 23:04:42 PDT
Comment on attachment 100618 [details] Patch Did you test this functions ?
Ryuan Choi
Comment 3 2011-07-13 00:13:50 PDT
(In reply to comment #2) > (From update of attachment 100618 [details]) > Did you test this functions ? I tested gettimeofday version and ecore_time_unix_get. They return almost same value. (little bit different because time elapsed after calling one and other). In case of ecore_time_get, you can reference below document. http://docs.enlightenment.org/auto/ecore/group__Ecore__Time__Group.html#ga43846b079394bb4d098abf5c16dfc544 Because ecore_time_get use monotonic clock, it cover functionality of monotonicallyIncreasingTime.
Gyuyoung Kim
Comment 4 2011-07-13 03:03:02 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 100618 [details] [details]) > > Did you test this functions ? > > I tested gettimeofday version and ecore_time_unix_get. > They return almost same value. > (little bit different because time elapsed after calling one and other). > > In case of ecore_time_get, you can reference below document. > http://docs.enlightenment.org/auto/ecore/group__Ecore__Time__Group.html#ga43846b079394bb4d098abf5c16dfc544 > > Because ecore_time_get use monotonic clock, it cover functionality of monotonicallyIncreasingTime. Implementation of ecore_time_unix_get() uses gettimeofday as well. So, it looks there is no problem.
Raphael Kubo da Costa (:rakuco)
Comment 5 2011-07-13 06:55:21 PDT
LGTM.
WebKit Review Bot
Comment 6 2011-07-25 00:19:04 PDT
Comment on attachment 100618 [details] Patch Clearing flags on attachment: 100618 Committed r91660: <http://trac.webkit.org/changeset/91660>
WebKit Review Bot
Comment 7 2011-07-25 00:19:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.