| Summary: | Web Inspector: make TextViewerDelegate methods implementations public in SourceFrame. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Podivilov <podivilov> | ||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Pavel Podivilov <podivilov> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Pavel Podivilov
2011-07-12 05:01:39 PDT
Created attachment 100469 [details]
Patch
Comment on attachment 100469 [details] Patch Attachment 100469 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9020143 New failing tests: http/tests/misc/slow-loading-mask.html fast/blockflow/japanese-rl-selection.html svg/transforms/text-with-mask-with-svg-transform.svg fast/backgrounds/background-leakage.html fast/box-shadow/scaled-box-shadow.html fast/backgrounds/repeat/negative-offset-repeat.html svg/W3C-SVG-1.1/struct-use-01-t.svg transforms/2d/hindi-rotated.html inspector/debugger/live-edit.html svg/repaint/filter-repaint.svg fast/blockflow/japanese-lr-selection.html Created attachment 100471 [details]
Archive of layout-test-results from ec2-cr-linux-01
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 100473 [details]
Patch
Comment on attachment 100473 [details]
Patch
Why?
(In reply to comment #5) > (From update of attachment 100473 [details]) > Why? Because derived classes (e.g. EditableResourceSourceFrame) override this methods. Committed r90818: <http://trac.webkit.org/changeset/90818> |