Bug 64353 - Web Inspector: make TextViewerDelegate methods implementations public in SourceFrame.
Summary: Web Inspector: make TextViewerDelegate methods implementations public in Sour...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-12 05:01 PDT by Pavel Podivilov
Modified: 2011-07-12 07:49 PDT (History)
12 users (show)

See Also:


Attachments
Patch (5.63 KB, patch)
2011-07-12 05:07 PDT, Pavel Podivilov
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-01 (1.30 MB, application/zip)
2011-07-12 05:24 PDT, WebKit Review Bot
no flags Details
Patch (7.31 KB, patch)
2011-07-12 05:30 PDT, Pavel Podivilov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-07-12 05:01:39 PDT
Web Inspector: make TextViewerDelegate methods implementations public in SourceFrame.

So derived classes can override those.
Comment 1 Pavel Podivilov 2011-07-12 05:07:50 PDT
Created attachment 100469 [details]
Patch
Comment 2 WebKit Review Bot 2011-07-12 05:24:43 PDT
Comment on attachment 100469 [details]
Patch

Attachment 100469 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9020143

New failing tests:
http/tests/misc/slow-loading-mask.html
fast/blockflow/japanese-rl-selection.html
svg/transforms/text-with-mask-with-svg-transform.svg
fast/backgrounds/background-leakage.html
fast/box-shadow/scaled-box-shadow.html
fast/backgrounds/repeat/negative-offset-repeat.html
svg/W3C-SVG-1.1/struct-use-01-t.svg
transforms/2d/hindi-rotated.html
inspector/debugger/live-edit.html
svg/repaint/filter-repaint.svg
fast/blockflow/japanese-lr-selection.html
Comment 3 WebKit Review Bot 2011-07-12 05:24:47 PDT
Created attachment 100471 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 4 Pavel Podivilov 2011-07-12 05:30:56 PDT
Created attachment 100473 [details]
Patch
Comment 5 Pavel Feldman 2011-07-12 05:33:19 PDT
Comment on attachment 100473 [details]
Patch

Why?
Comment 6 Pavel Podivilov 2011-07-12 06:00:24 PDT
(In reply to comment #5)
> (From update of attachment 100473 [details])
> Why?

Because derived classes (e.g. EditableResourceSourceFrame) override this methods.
Comment 7 Pavel Podivilov 2011-07-12 07:49:58 PDT
Committed r90818: <http://trac.webkit.org/changeset/90818>