RESOLVED FIXED64353
Web Inspector: make TextViewerDelegate methods implementations public in SourceFrame. 
https://bugs.webkit.org/show_bug.cgi?id=64353
Summary Web Inspector: make TextViewerDelegate methods implementations public in Sour...
Pavel Podivilov
Reported 2011-07-12 05:01:39 PDT
Web Inspector: make TextViewerDelegate methods implementations public in SourceFrame. So derived classes can override those.
Attachments
Patch (5.63 KB, patch)
2011-07-12 05:07 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-01 (1.30 MB, application/zip)
2011-07-12 05:24 PDT, WebKit Review Bot 		no flags
Details
Patch (7.31 KB, patch)
2011-07-12 05:30 PDT, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-07-12 05:07:50 PDT
Created attachment 100469 [details] Patch
WebKit Review Bot
Comment 2 2011-07-12 05:24:43 PDT
Comment on attachment 100469 [details] Patch Attachment 100469 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9020143 New failing tests: http/tests/misc/slow-loading-mask.html fast/blockflow/japanese-rl-selection.html svg/transforms/text-with-mask-with-svg-transform.svg fast/backgrounds/background-leakage.html fast/box-shadow/scaled-box-shadow.html fast/backgrounds/repeat/negative-offset-repeat.html svg/W3C-SVG-1.1/struct-use-01-t.svg transforms/2d/hindi-rotated.html inspector/debugger/live-edit.html svg/repaint/filter-repaint.svg fast/blockflow/japanese-lr-selection.html
WebKit Review Bot
Comment 3 2011-07-12 05:24:47 PDT
Created attachment 100471 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Pavel Podivilov
Comment 4 2011-07-12 05:30:56 PDT
Created attachment 100473 [details] Patch
Pavel Feldman
Comment 5 2011-07-12 05:33:19 PDT
Comment on attachment 100473 [details] Patch Why?
Pavel Podivilov
Comment 6 2011-07-12 06:00:24 PDT
(In reply to comment #5) > (From update of attachment 100473 [details]) > Why? Because derived classes (e.g. EditableResourceSourceFrame) override this methods.
Pavel Podivilov
Comment 7 2011-07-12 07:49:58 PDT
Committed r90818: <http://trac.webkit.org/changeset/90818>
Note You need to log in before you can comment on or make changes to this bug.