Bug 64348

Summary: Unquoted string "attributes" may clash with future reserved word at ../../Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm line 1058.
Product: WebKit Reporter: arno. <a.renevier>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dbates, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

arno.
Reported 2011-07-12 01:36:35 PDT
Hi, when building webkit-gtk with annotations, warning is issued multiple times from CodeGeneratorGObject.pm
Attachments
patch (1.63 KB, patch)
2011-07-12 01:48 PDT, arno. 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
arno.
Comment 1 2011-07-12 01:48:42 PDT
Created attachment 100450 [details] patch
Eric Seidel (no email)
Comment 2 2011-09-12 17:02:50 PDT
Comment on attachment 100450 [details] patch Huh? I'm confused by this perl.
Darin Adler
Comment 3 2011-10-17 09:33:11 PDT
Comment on attachment 100450 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=100450&action=review > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1058 > - $param->extendedAttributes(attributes); > + $param->extendedAttributes("attributes"); After reviewing, I realized that I don’t really understand this line. It looks like it fetches a value that is never used.
WebKit Review Bot
Comment 4 2011-10-17 16:14:08 PDT
Comment on attachment 100450 [details] patch Clearing flags on attachment: 100450 Committed r97664: <http://trac.webkit.org/changeset/97664>
WebKit Review Bot
Comment 5 2011-10-17 16:14:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.