Summary: | Unquoted string "attributes" may clash with future reserved word at ../../Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm line 1058. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | arno. <a.renevier> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, dbates, eric, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
arno.
2011-07-12 01:36:35 PDT
Created attachment 100450 [details]
patch
Comment on attachment 100450 [details]
patch
Huh? I'm confused by this perl.
Comment on attachment 100450 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=100450&action=review > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1058 > - $param->extendedAttributes(attributes); > + $param->extendedAttributes("attributes"); After reviewing, I realized that I don’t really understand this line. It looks like it fetches a value that is never used. Comment on attachment 100450 [details] patch Clearing flags on attachment: 100450 Committed r97664: <http://trac.webkit.org/changeset/97664> All reviewed patches have been landed. Closing bug. |