Bug 64333

Summary: Rename AutoFill -> Autofill
Product: WebKit Reporter: Ilya Sherman <isherman>
Component: New BugsAssignee: Ilya Sherman <isherman>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, isherman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
fishd: review+, webkit.review.bot: commit-queue-
Full diff, I hope
none
patch none

Ilya Sherman
Reported 2011-07-11 18:01:49 PDT
Rename AutoFill -> Autofill
Attachments
Patch (28.74 KB, patch)
2011-07-11 18:04 PDT, Ilya Sherman 		fishd: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Full diff, I hope (76.02 KB, patch)
2011-07-12 17:23 PDT, Ilya Sherman 		no flags
DetailsFormatted DiffDiff
patch (74.89 KB, patch)
2011-07-13 17:01 PDT, Ilya Sherman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ilya Sherman
Comment 1 2011-07-11 18:04:14 PDT
Created attachment 100397 [details] Patch
WebKit Review Bot
Comment 2 2011-07-11 18:25:46 PDT
Comment on attachment 100397 [details] Patch Attachment 100397 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9021003
WebKit Review Bot
Comment 3 2011-07-11 20:38:33 PDT
Comment on attachment 100397 [details] Patch Attachment 100397 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9021035
Darin Fisher (:fishd, Google)
Comment 4 2011-07-12 10:18:04 PDT
Comment on attachment 100397 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100397&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:926 > + if '/wtf/' in filename: wait, is this change really intended to be part of this patch?
Ilya Sherman
Comment 5 2011-07-12 17:23:52 PDT
Created attachment 100594 [details] Full diff, I hope
Ilya Sherman
Comment 6 2011-07-12 17:27:19 PDT
Re-uploaded the patch by hand, including the renamed files that "webkit-patch upload" dropped. Sorry for not noticing that sooner. (In reply to comment #4) > (From update of attachment 100397 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100397&action=review > > > Tools/Scripts/webkitpy/style/checkers/cpp.py:926 > > + if '/wtf/' in filename: > > wait, is this change really intended to be part of this patch? Yes. I can split this out to a separate patch if preferable; but the style checker was (incorrectly) complaining that the header guards in the renamed files were incorrect.
Darin Fisher (:fishd, Google)
Comment 7 2011-07-13 09:47:03 PDT
(In reply to comment #6) > Re-uploaded the patch by hand, including the renamed files that "webkit-patch upload" dropped. Sorry for not noticing that sooner. > > (In reply to comment #4) > > (From update of attachment 100397 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=100397&action=review > > > > > Tools/Scripts/webkitpy/style/checkers/cpp.py:926 > > > + if '/wtf/' in filename: > > > > wait, is this change really intended to be part of this patch? > > Yes. I can split this out to a separate patch if preferable; but the style checker was (incorrectly) complaining that the header guards in the renamed files were incorrect. ^^^ Yes, it is usually good to separate out separate issues into separate patches. In this case, I'm not the best reviewer for anything under webkitpy, and the bugzilla does not make it easy to request review from multiple people.
Ilya Sherman
Comment 8 2011-07-13 17:01:49 PDT
Created attachment 100732 [details] patch Split out the style checker change to a separate patch.
WebKit Review Bot
Comment 9 2011-07-14 09:43:05 PDT
Comment on attachment 100732 [details] patch Clearing flags on attachment: 100732 Committed r91004: <http://trac.webkit.org/changeset/91004>
WebKit Review Bot
Comment 10 2011-07-14 09:43:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.