Rename AutoFill -> Autofill

• Component: New Bugs
• Status: RESOLVED FIXED

[Ilya Sherman]

Rename AutoFill -> Autofill

[Ilya Sherman]

Created attachment 100397 [details]
Patch

[WebKit Review Bot]

Comment on attachment 100397 [details]
Patch

Attachment 100397 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9021003

[WebKit Review Bot]

Comment on attachment 100397 [details]
Patch

Attachment 100397 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/9021035

[Darin Fisher (:fishd, Google)]

Comment on attachment 100397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100397&action=review

> Tools/Scripts/webkitpy/style/checkers/cpp.py:926
> +    if '/wtf/' in filename:

wait, is this change really intended to be part of this patch?

[Ilya Sherman]

Created attachment 100594 [details]
Full diff, I hope

[Ilya Sherman]

Re-uploaded the patch by hand, including the renamed files that "webkit-patch upload" dropped.  Sorry for not noticing that sooner.

(In reply to comment #4)
> (From update of attachment 100397 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100397&action=review
> 
> > Tools/Scripts/webkitpy/style/checkers/cpp.py:926
> > +    if '/wtf/' in filename:
> 
> wait, is this change really intended to be part of this patch?

Yes.  I can split this out to a separate patch if preferable; but the style checker was (incorrectly) complaining that the header guards in the renamed files were incorrect.

[Darin Fisher (:fishd, Google)]

(In reply to comment #6)
> Re-uploaded the patch by hand, including the renamed files that "webkit-patch upload" dropped.  Sorry for not noticing that sooner.
> 
> (In reply to comment #4)
> > (From update of attachment 100397 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=100397&action=review
> > 
> > > Tools/Scripts/webkitpy/style/checkers/cpp.py:926
> > > +    if '/wtf/' in filename:
> > 
> > wait, is this change really intended to be part of this patch?
> 
> Yes.  I can split this out to a separate patch if preferable; but the style checker was (incorrectly) complaining that the header guards in the renamed files were incorrect.

^^^ Yes, it is usually good to separate out separate issues into separate patches.  In this case, I'm not the best reviewer for anything under webkitpy, and the bugzilla does not make it easy to request review from multiple people.

[Ilya Sherman]

Created attachment 100732 [details]
patch

Split out the style checker change to a separate patch.

[WebKit Review Bot]

Comment on attachment 100732 [details]
patch

Clearing flags on attachment: 100732

Committed r91004: <http://trac.webkit.org/changeset/91004>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.