Bug 64326

Summary: Change roundedIntRect to roundedRect
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eae, eric, gustavo, jamesr, simon.fraser, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 63567    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Levi Weintraub
Reported 2011-07-11 16:46:02 PDT
roundedIntRect should be based on Layout units, so I'm renaming it to "roundedRect"
Attachments
Patch (90.29 KB, patch)
2011-07-11 17:32 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch for landing (91.62 KB, patch)
2011-07-12 10:16 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch for landing (108.47 KB, patch)
2011-07-12 11:11 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-07-11 17:32:54 PDT
Created attachment 100390 [details] Patch
Eric Seidel (no email)
Comment 2 2011-07-11 17:42:34 PDT
Comment on attachment 100390 [details] Patch Seems OK. Could also be RoundedLayoutRect.
Simon Fraser (smfr)
Comment 3 2011-07-11 17:43:54 PDT
Actually I think when used in GraphicsContext methods, it should always be a float-based.
Gyuyoung Kim
Comment 4 2011-07-11 18:00:39 PDT
Comment on attachment 100390 [details] Patch Attachment 100390 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9009779
Gustavo Noronha (kov)
Comment 5 2011-07-11 18:11:16 PDT
Comment on attachment 100390 [details] Patch Attachment 100390 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9012651
Levi Weintraub
Comment 6 2011-07-12 10:16:07 PDT
Created attachment 100506 [details] Patch for landing
Levi Weintraub
Comment 7 2011-07-12 10:19:06 PDT
(In reply to comment #3) > Actually I think when used in GraphicsContext methods, it should always be a float-based. I think you're right. We plan on auditing all the rounding as part of our process. It'll be one of the most fun parts :)
Levi Weintraub
Comment 8 2011-07-12 10:45:02 PDT
Comment on attachment 100506 [details] Patch for landing Just realized I missed one more file. Fixing and re-uploading.
Levi Weintraub
Comment 9 2011-07-12 11:11:02 PDT
Created attachment 100525 [details] Patch for landing
WebKit Review Bot
Comment 10 2011-07-12 11:37:24 PDT
Comment on attachment 100525 [details] Patch for landing Clearing flags on attachment: 100525 Committed r90832: <http://trac.webkit.org/changeset/90832>
WebKit Review Bot
Comment 11 2011-07-12 11:37:29 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 12 2011-07-12 11:39:23 PDT
This is a layer violation. Layout units is a higher level concept in the rendering engine, not one that should exist at the platform level. If we can move to floating point for the rounded rectangle arguments for graphics context arguments, then we should do so. It seems like a very bad idea to have the graphics context layer be built on top of the layout units concept.
Simon Fraser (smfr)
Comment 13 2011-07-12 11:55:47 PDT
Agree with Darin
Note You need to log in before you can comment on or make changes to this bug.