Bug 64324 – webkit-patch roll-chromium-deps no longer works

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Ryosuke Niwa]

webkit-patch roll-chromium-deps blows up with the following trace:

  File "Tools/Scripts/webkit-patch", line 66, in <module>
    main()
  File "Tools/Scripts/webkit-patch", line 61, in main
    WebKitPatch(__file__).main()
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 51, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/steps/commit.py", line 48, in run
    raise Exception("Attempted to commit with a commit message shorter than 50 characters.  Either your patch is missing a ChangeLog or webkit-patch may have a bug.")

[Ryosuke Niwa]

Created attachment 100379 [details]
Patch

[Adam Barth]

Comment on attachment 100379 [details]
Patch

Did you run test-webkitpy?

[James Robinson]

Comment on attachment 100379 [details]
Patch

R=me but please file a bug to make this check actually do what it claims it's trying to do (checking for a ChangeLog on the patch).

[Ryosuke Niwa]

Committed r90793: <http://trac.webkit.org/changeset/90793>