Bug 64324

Summary: webkit-patch roll-chromium-deps no longer works
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch jamesr: review+

Ryosuke Niwa
Reported 2011-07-11 16:30:46 PDT
webkit-patch roll-chromium-deps blows up with the following trace: File "Tools/Scripts/webkit-patch", line 66, in <module> main() File "Tools/Scripts/webkit-patch", line 61, in main WebKitPatch(__file__).main() File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 51, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors self._run(tool, options, state) File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/steps/commit.py", line 48, in run raise Exception("Attempted to commit with a commit message shorter than 50 characters. Either your patch is missing a ChangeLog or webkit-patch may have a bug.")
Attachments
Patch (1.49 KB, patch)
2011-07-11 16:32 PDT, Ryosuke Niwa
jamesr: review+
Ryosuke Niwa
Comment 1 2011-07-11 16:32:32 PDT
Adam Barth
Comment 2 2011-07-11 16:33:06 PDT
Comment on attachment 100379 [details] Patch Did you run test-webkitpy?
James Robinson
Comment 3 2011-07-11 16:33:31 PDT
Comment on attachment 100379 [details] Patch R=me but please file a bug to make this check actually do what it claims it's trying to do (checking for a ChangeLog on the patch).
Ryosuke Niwa
Comment 4 2011-07-11 16:35:17 PDT
Note You need to log in before you can comment on or make changes to this bug.