Bug 64289

Summary:

[Qt][WK2] Get rid of focusNextPrevChild()

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

UI Events

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kling, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+, kling: commit-queue-

Description Benjamin Poulain 2011-07-11 09:20:45 PDT

Qt 5 does not support focusNextPrevChild(). We should get rid of that for now.

Comment 1 Benjamin Poulain 2011-07-11 09:32:20 PDT

Created attachment 100312 [details]
Patch

Comment 2 Andreas Kling 2011-07-11 09:38:50 PDT

Comment on attachment 100312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100312&action=review

r=me.

> Source/WebKit2/UIProcess/qt/ClientImpl.cpp:172
>  void qt_wk_takeFocus(WKPageRef page, WKFocusDirection direction, const void *clientInfo)

You could get rid of this ClientImpl method.

Comment 3 Andreas Kling 2011-07-11 10:10:55 PDT

Comment on attachment 100312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100312&action=review

You asked for it..

> Source/WebKit2/ChangeLog:3
> +        [Qt][WK2] Get rid of the focusNextPrevChild()

s/the//

Comment 4 Benjamin Poulain 2011-07-11 11:22:38 PDT

Committed r90766: <http://trac.webkit.org/changeset/90766>