Bug 64289

Summary:

[Qt][WK2] Get rid of focusNextPrevChild()

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

UI Events

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kling, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+, kling: commit-queue-

Benjamin Poulain

Reported 2011-07-11 09:20:45 PDT

Qt 5 does not support focusNextPrevChild(). We should get rid of that for now.

Attachments
Patch (4.34 KB, patch) 2011-07-11 09:32 PDT, Benjamin Poulain	kling: review+ kling: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2011-07-11 09:32:20 PDT

Andreas Kling

Comment 2 2011-07-11 09:38:50 PDT

Comment on attachment 100312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100312&action=review r=me. > Source/WebKit2/UIProcess/qt/ClientImpl.cpp:172 > void qt_wk_takeFocus(WKPageRef page, WKFocusDirection direction, const void *clientInfo) You could get rid of this ClientImpl method.

Andreas Kling

Comment 3 2011-07-11 10:10:55 PDT

Comment on attachment 100312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100312&action=review You asked for it.. > Source/WebKit2/ChangeLog:3 > + [Qt][WK2] Get rid of the focusNextPrevChild() s/the//

Benjamin Poulain

Comment 4 2011-07-11 11:22:38 PDT

Note You need to log in before you can comment on or make changes to this bug.