Bug 64274

Summary:

Web Inspector: make SourceFrame a View.

Product:

WebKit

Reporter:

Pavel Podivilov <podivilov>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Podivilov <podivilov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch.	pfeldman: review-
Patch.	pfeldman: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-03	none

Pavel Podivilov

Reported 2011-07-11 06:23:32 PDT

Web Inspector: make SourceFrame a View.

Attachments
Patch. (6.35 KB, patch) 2011-07-11 06:24 PDT, Pavel Podivilov	pfeldman: review-	Details Formatted Diff Diff
Patch. (9.72 KB, patch) 2011-07-11 06:49 PDT, Pavel Podivilov	pfeldman: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-03 (1.70 MB, application/zip) 2011-07-11 07:05 PDT, WebKit Review Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pavel Podivilov

Comment 1 2011-07-11 06:24:14 PDT

Created attachment 100287 [details] Patch.

Pavel Feldman

Comment 2 2011-07-11 06:40:34 PDT

Comment on attachment 100287 [details] Patch. This patch looks wrong.

Pavel Podivilov

Comment 3 2011-07-11 06:49:22 PDT

Created attachment 100292 [details] Patch.

WebKit Review Bot

Comment 4 2011-07-11 07:05:53 PDT

Comment on attachment 100292 [details] Patch. Attachment 100292 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9012446 New failing tests: http/tests/misc/slow-loading-mask.html fast/blockflow/japanese-rl-selection.html svg/transforms/text-with-mask-with-svg-transform.svg fast/backgrounds/background-leakage.html fast/box-shadow/scaled-box-shadow.html fast/backgrounds/repeat/negative-offset-repeat.html svg/W3C-SVG-1.1/struct-use-01-t.svg transforms/2d/hindi-rotated.html inspector/debugger/live-edit.html svg/repaint/filter-repaint.svg fast/blockflow/japanese-lr-selection.html

WebKit Review Bot

Comment 5 2011-07-11 07:05:57 PDT

Created attachment 100294 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Pavel Podivilov

Comment 6 2011-07-11 07:09:41 PDT

Committed r90743: <http://trac.webkit.org/changeset/90743>

Adam Barth

Comment 7 2011-07-11 10:49:45 PDT

Were these failures not real?

Pavel Podivilov

Comment 8 2011-07-11 10:52:53 PDT

(In reply to comment #7) > Were these failures not real? Looks so, except for the inspector/debugger/live-edit.html.

Adam Barth

Comment 9 2011-07-11 10:53:56 PDT

Thanks. Looks like the bot might be sick.

Note You need to log in before you can comment on or make changes to this bug.