Bug 64226

Summary:	check-webkit-style should maybe use pylint instead of pep8
Product:	WebKit	Reporter:	Dirk Pranke <dpranke>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	NEW
Severity:	Normal	CC:	abarth, aroben, eric
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified

Dirk Pranke

Reported 2011-07-08 18:53:27 PDT

Pylint catches a whole lot more things than PEP-8 does (although it's quite a bit slower). We could consider pyflakes as an alternative as well, but I think we should favor comprehensiveness over speed unless demonstrated to be a problem.

Attachments
Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2011-07-09 03:38:27 PDT

I think we just want to add more pre-upload steps besides check-webkit-style. Maybe a check-patch command which runs a whoel bunch of these.

Adam Roben (:aroben)

Comment 2 2011-07-09 12:07:24 PDT

What kinds of things do these other tools check for that pep8 doesn't?

Note You need to log in before you can comment on or make changes to this bug.