Bug 64203

Summary: Lists of flaky revisions on TestFailures page can get so long they're hard to navigate
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dbates, ddkilzer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dbates: review+

Description Adam Roben (:aroben) 2011-07-08 14:24:57 PDT 
Lists of flaky revisions on TestFailures page can get so long they're hard to navigate
Comment 1 Adam Roben (:aroben) 2011-07-08 14:25:52 PDT 
Created attachment 100163 [details]
Patch
Comment 2 Daniel Bates 2011-07-08 15:44:25 PDT 
Comment on attachment 100163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100163&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:513
> +                    item.appendChild(document.createTextNode('\u22ee'));

Nit: I would suggest either defining a const VerticalEllipsis = '\u22ee' or putting an inline comment here, like // Vertical ellipsis.
Comment 3 Daniel Bates 2011-07-08 15:49:14 PDT 
Comment on attachment 100163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100163&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:93
> +        const startAndEndAbbreviatedExamplesCount = 3;

The code also assumes that this is constant is always >= 1. Maybe we should have a comment to state this.
Comment 4 Daniel Bates 2011-07-08 15:50:39 PDT 
(In reply to comment #3)
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:93
> > +        const startAndEndAbbreviatedExamplesCount = 3;
> 
> The code also assumes that this is constant is always >= 1. Maybe we should have a comment to state this.

I mean't to write that the constant must always be > 1.
Comment 5 Adam Roben (:aroben) 2011-07-09 12:04:18 PDT 
Comment on attachment 100163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100163&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:93
>> +        const startAndEndAbbreviatedExamplesCount = 3;
> 
> The code also assumes that this is constant is always >= 1. Maybe we should have a comment to state this.

Added a console.assert.

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:513
>> +                    item.appendChild(document.createTextNode('\u22ee'));
> 
> Nit: I would suggest either defining a const VerticalEllipsis = '\u22ee' or putting an inline comment here, like // Vertical ellipsis.

Done.
Comment 6 Adam Roben (:aroben) 2011-07-09 12:06:08 PDT 
Committed r90682: <http://trac.webkit.org/changeset/90682>