Summary: | TestResultsServer should keep old test results | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, ojan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 64189 | ||||||||
Attachments: |
|
Description
Adam Barth
2011-07-08 13:38:43 PDT
Created attachment 100155 [details]
Patch
Comment on attachment 100155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100155&action=review > Tools/ChangeLog:8 > + Having historical data will help use do failure archeology. s/use/us > Tools/TestResultServer/handlers/testfilehandler.py:107 > + if callback_name: If callback_name is optional, it should default to None above, right? > Tools/TestResultServer/handlers/testfilehandler.py:133 > + file = db.get(key) Not entirely sure what this does. What are valid values for "key"? > Tools/TestResultServer/templates/showfilelist.jsonp:4 > +{% for file in files %} > + "{{ file.key }}", > +{% endfor %} Do we want to use a richer format for this? For example, do we want to include the metadata we have about each file? Basically the data we currently show at http://test-results.appspot.com/testfile. > > Tools/TestResultServer/handlers/testfilehandler.py:133 > > + file = db.get(key) > > Not entirely sure what this does. What are valid values for "key"? AppEngine datastore keys. > > Tools/TestResultServer/templates/showfilelist.jsonp:4 > > +{% for file in files %} > > + "{{ file.key }}", > > +{% endfor %} > > Do we want to use a richer format for this? For example, do we want to include the metadata we have about each file? Basically the data we currently show at http://test-results.appspot.com/testfile. I'll add some more structure here so that it is future-proof. Created attachment 100159 [details]
Patch
Committed r90665: <http://trac.webkit.org/changeset/90665> |