Bug 64197

Summary: checkout_unittest contains ugly, fragile code to find the Scripts directory
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adam Roben (:aroben)
Reported 2011-07-08 12:50:08 PDT
checkout_unittest contains ugly, fragile code to find the Scripts directory
Attachments
Patch (2.74 KB, patch)
2011-07-08 12:50 PDT, Adam Roben (:aroben) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-07-08 12:50:45 PDT
Created attachment 100148 [details] Patch
Adam Barth
Comment 2 2011-07-08 12:52:48 PDT
Comment on attachment 100148 [details] Patch We're generally careful about leaking real objects through mocks, but this looks pretty safe. Thanks.
WebKit Review Bot
Comment 3 2011-07-08 13:02:39 PDT
Comment on attachment 100148 [details] Patch Clearing flags on attachment: 100148 Committed r90659: <http://trac.webkit.org/changeset/90659>
WebKit Review Bot
Comment 4 2011-07-08 13:02:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.