Bug 64190

Summary: garden-o-matic should be able to determine when compile breaks
Product: WebKit Reporter: Adam Barth <abarth>
Component: Tools / TestsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 64588    
Bug Blocks: 64188    
Attachments:
Description Flags
Needs tests
none
Patch
none
Patch for landing
none
Patch for landing webkit.review.bot: commit-queue-

Description Adam Barth 2011-07-08 11:27:18 PDT 
Compile breaks are high-priority failures because they prevent the gardener from getting test coverage while the compile is broken.
Comment 1 Adam Barth 2011-07-15 03:13:05 PDT 
Created attachment 100951 [details]
Needs tests
Comment 2 Adam Barth 2011-07-15 16:03:09 PDT 
Created attachment 101062 [details]
Patch
Comment 3 Dimitri Glazkov (Google) 2011-07-15 16:07:17 PDT 
Comment on attachment 101062 [details]
Patch

I assume you already have the Python code to supply breakage info in place?
Comment 4 Adam Barth 2011-07-15 16:08:39 PDT 
> I assume you already have the Python code to supply breakage info in place?

Yes.  Eric reviewed that patch already.
Comment 5 Adam Barth 2011-07-15 16:10:43 PDT 
Created attachment 101063 [details]
Patch for landing
Comment 6 Adam Barth 2011-07-15 16:11:11 PDT 
Created attachment 101064 [details]
Patch for landing
Comment 7 WebKit Review Bot 2011-07-15 18:12:34 PDT 
Comment on attachment 101064 [details]
Patch for landing

Rejecting attachment 101064 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 1

Last 500 characters of output:
3db9c0907c35169d12d473037cbe22b315c96bc3
r91136 = 56184685e69fdba85512030fe4b830960645853c
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9095523
Comment 8 Adam Barth 2011-07-18 11:18:52 PDT 
Committed r91196: <http://trac.webkit.org/changeset/91196>