Summary: | [Qt][WK2] Views should expose QActions for basic navigation. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
Component: | WebKit Qt | Assignee: | Andreas Kling <kling> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Andreas Kling
2011-07-08 10:14:12 PDT
Created attachment 100130 [details]
Proposed patch
Comment on attachment 100130 [details]
Proposed patch
Needs tests :)
(In reply to comment #2) > (From update of attachment 100130 [details]) > Needs tests :) Ah duh, in the CommonViewInterface of course. I also realized that for the mobile view, the page should have the navigation actions, not the view. Cookin' a new one for ya. Created attachment 100136 [details]
Proposed patch v2
Comment on attachment 100136 [details] Proposed patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=100136&action=review > Tools/MiniBrowser/qt/BrowserView.cpp:97 > + return touchWebView()->navigationAction(which); Should be touchWebView()->page()->..., will fix when landing. Attachment 100136 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Source/WebKit2/UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:20: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 2 in 18 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 100136 [details] Proposed patch v2 Attachment 100136 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9000616 Comment on attachment 100136 [details] Proposed patch v2 Stylebot + > Tools/MiniBrowser/qt/BrowserView.cpp:98 > + Q_ASSERT(0); Q_ASSERT(false) Committed r90647: <http://trac.webkit.org/changeset/90647> |