Bug 64172 – [Qt] Avoid using setSelectionRange in ::inputMethodEvent as it does not work for contentEditable

• Component: HTML Editing
• Status: RESOLVED INVALID

[Kenneth Rohde Christiansen]

SSIA

[Kenneth Rohde Christiansen]

Created attachment 100123 [details]
Patch

[Kenneth Rohde Christiansen]

Kling/Laszlo, do you know who might be able to test this? I guess they are using it for Symbian.

[Enrica Casucci]

Comment on attachment 100123 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100123&action=review

The patch looks fine, but I'd like to see the variable name changed.

> Source/WebKit/qt/Api/qwebpage.cpp:1084
> +    Element* node = 0;

Please rename the variable and its references below.

[Simon Hausmann]

Comment on attachment 100123 [details]
Patch

r=me, but I agree with Enrica. Although that could also be done in a separate patch if you want. Please also make sure that the existing input method tests still pass :)

[Michael Brüning]

Checking this because it was on the reminder list - it seems that this patch is obsolete / was rewritten and landed already. 

Kenneth, Simon, do you agree?

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.