Bug 64159

Summary:

[GTK] testwebview API test fails after http://trac.webkit.org/changeset/90471

Product:

WebKit

Reporter:

Gustavo Noronha (kov) <gustavo>

Component:

WebKitGTK

Assignee:

Gustavo Noronha (kov) <gustavo>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

Gtk

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Gustavo Noronha (kov) 2011-07-08 05:11:00 PDT

We relied on the page being considered loaded for checking the icon signals. The page is now considered loaded before the favicon change happens, so the test broke.

Comment 1 Gustavo Noronha (kov) 2011-07-08 05:19:55 PDT

Created attachment 100107 [details]
Patch

Comment 2 Xan Lopez 2011-07-08 06:37:05 PDT

Comment on attachment 100107 [details]
Patch

If you add a reference to the changeset where this changed I'll like you even more!

Comment 3 Gustavo Noronha (kov) 2011-07-08 06:43:00 PDT

Comment on attachment 100107 [details]
Patch

Clearing flags on attachment: 100107

Committed r90627: <http://trac.webkit.org/changeset/90627>

Comment 4 Gustavo Noronha (kov) 2011-07-08 06:43:07 PDT

All reviewed patches have been landed.  Closing bug.