Bug 64159 - [GTK] testwebview API test fails after http://trac.webkit.org/changeset/90471
Summary: [GTK] testwebview API test fails after http://trac.webkit.org/changeset/90471
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-07-08 05:11 PDT by Gustavo Noronha (kov)
Modified: 2011-07-08 06:43 PDT (History)
0 users

See Also:


Attachments
Patch (3.40 KB, patch)
2011-07-08 05:19 PDT, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2011-07-08 05:11:00 PDT
We relied on the page being considered loaded for checking the icon signals. The page is now considered loaded before the favicon change happens, so the test broke.
Comment 1 Gustavo Noronha (kov) 2011-07-08 05:19:55 PDT
Created attachment 100107 [details]
Patch
Comment 2 Xan Lopez 2011-07-08 06:37:05 PDT
Comment on attachment 100107 [details]
Patch

If you add a reference to the changeset where this changed I'll like you even more!
Comment 3 Gustavo Noronha (kov) 2011-07-08 06:43:00 PDT
Comment on attachment 100107 [details]
Patch

Clearing flags on attachment: 100107

Committed r90627: <http://trac.webkit.org/changeset/90627>
Comment 4 Gustavo Noronha (kov) 2011-07-08 06:43:07 PDT
All reviewed patches have been landed.  Closing bug.