Bug 64149 – Write a tools library to manipulate Qt project files

• Component: Tools / Tests
• Status: RESOLVED INVALID

[Roland Steiner]

The webkit-file tool project requires a module to manipulate Qt project files.

[Roland Steiner]

Created attachment 100091 [details]
work-in-progress

[Roland Steiner]

Created attachment 100092 [details]
WebCore.pro original

Sample demonstrating the output - the original WebCore.pro file

[Roland Steiner]

Created attachment 100093 [details]
Reference output of tool

Result of writing above file back using the tool, which is sorted and cleaned. Please holler if you find modifications that are unacceptable!

[Tony Chang]

Adding some Qt devs.

[Roland Steiner]

I'm currently in the process of refactoring and updating the tool suite. New version should come shortly.

[Roland Steiner]

Created attachment 134775 [details]
patch, requires 82595

first review version. Unit tests are subsumed by unit tests for webkitfile.py (see bug 81317)

[Tor Arne Vestbø]

Hmm, I'm not sure manipulating the project files of each build system directly is the way to go (I assume that's the plan?). Have anyone investigated using a generic list of things to build that's then included by each build system? So we would only change the list of files in one place, similar to how the sources and IDL files are shared (with a few ifdefs here and there).

[Jocelyn Turcotte]

(In reply to comment #7)
> Hmm, I'm not sure manipulating the project files of each build system directly is the way to go (I assume that's the plan?). Have anyone investigated using a generic list of things to build that's then included by each build system? So we would only change the list of files in one place, similar to how the sources and IDL files are shared (with a few ifdefs here and there).

If other ports could agree on such a generic importable text list I think it could be easier to maintain as well.

Another way to avoid the build system to become less human readable and having to handle every edge cases of .pro files syntaxes in the tool would be to keep the easy to parse cpp/h file list between magic delimiters in the file. That can easily handle 90% of the file adds/removals, would keep the complex parts of the file easier to organize and would fit well with the webkit-file interface.
Something like:

# === BEGIN FILE LIST ===

SOURCES += \
  FileA.cpp

HEADERS += \
  FileA.h

enable?(ICONDATABASE) {
  SOURCES += \
    loader/icon/IconDatabase.cpp
}

# === END FILE LIST ===
...
weird:qmake { syntax | STATEMENT }
...

[Anders Carlsson]

Comment on attachment 134775 [details]
patch, requires 82595

Qt has been removed, clearing review flags.