Summary: | DFG JIT does not implement prototype chain or list caching for get_by_id | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Filip Pizlo
2011-07-07 22:09:54 PDT
Created attachment 100071 [details]
the patch
Attachment 100071 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/dfg/DFGRepatch.cpp:400: One line control clauses should not use braces. [whitespace/braces] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 100079 [details]
the patch (fix style)
Comment on attachment 100079 [details] the patch (fix style) View in context: https://bugs.webkit.org/attachment.cgi?id=100079&action=review Sorry, just one minor style nit. > Source/JavaScriptCore/dfg/DFGRepatch.cpp:225 > + return false; Please lose the { } here. (In reply to comment #4) > (From update of attachment 100079 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100079&action=review > > Sorry, just one minor style nit. > > > Source/JavaScriptCore/dfg/DFGRepatch.cpp:225 > > + return false; > > Please lose the { } here. Ah, right. Thanks for catching that. Will fix that. Created attachment 100692 [details] the patch This patch subsumes https://bugs.webkit.org/show_bug.cgi?id=64077, in that the implementation of prototype chain and list caching involved redoing prototype caching. I did it this way to make prototype caching, prototype chain caching, prototype list caching, and prototype list chain caching. Comment on attachment 100692 [details] the patch Clearing flags on attachment: 100692 Committed r90950: <http://trac.webkit.org/changeset/90950> All reviewed patches have been landed. Closing bug. |